remove stage from generated http request url #451
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calavera
suggested changes
Mar 21, 2022
Contributor
calavera
left a comment
calavera
left a comment
There was a problem hiding this comment.
I'm not sure about this, tbh. I'd like to understand why this needs to be reverted when it was a fix for a customer problem.
see for context on this behavior, #107
See my comment about stage behavior here: #450 (comment)
2 tasks
Contributor
|
@bnusunny please open a different pull request for the User-Agent change. |
Collaborator
Author
|
Sorry. My mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Issue #450
Description of changes:
This PR removes stage from generated http request url. This is the behavior in v0.4.1.
By submitting this pull request